Fix concurrency properly in File CA implementation #495
+5
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last fix guarded against writes, but as pointed out in another PR, the set of certificates could change between fetching the cert/key pair, and using the cert chain in the response. The fix simply reads the cert chain and private key once. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Codecov Report
@@ Coverage Diff @@
## main #495 +/- ##
==========================================
+ Coverage 47.84% 47.97% +0.13%
==========================================
Files 14 14
Lines 1066 1063 -3
==========================================
Hits 510 510
+ Misses 483 480 -3
Partials 73 73
Continue to review full report at Codecov.
|
bobcallaway
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last fix guarded against writes, but as pointed out in another PR,
the set of certificates could change between fetching the cert/key pair,
and using the cert chain in the response. The fix simply reads the cert
chain and private key once.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note